Maemo/MaemoGtkChanges

This page keeps track of all changes that are in Maemo-GTK+ and have not been backfolded to upstream GTK+. All new changes that are being done to Maemo-GTK+ that divert Maemo-GTK+ away from upstream GTK+ (ie. non-backport commits) must be documented on this page.

All question mark and check mark changes from Maemo/Gtk210Changes have been taken over on this page and marked with a new status accordingly. Any new commits to Maemo-GTK+ (that are not backmerges) will only appear on this page, as Maemo/Gtk210Changes will no longer be updated. Most question mark entries are still marked with a question mark; most checkmark entries are now blank entries, indicating a need for investigation.




Maemo-GTK+ changes compared to upstream GTK+

  • Status ( {1} )

    Meaning

    change has not been investigated and is not in upstream GTK+

    {X}

    change is not upstreamable

    /!\

    default property value differs from upstream

    ?

    Unclear to merge and/or unclear to test

    (./)

    change has been submitted to upstream GTK+, see Maemo/GtkContributions

    S

    Maemo-GTK+ 2.10 stub, needs investigation

    File

    {1}

    Comments

    acconfig.h

    {X}

    add MAEMO_CHANGES define

    configure.in

    {X}

    --with-maemo argument

    gdk/gdkinternals.h

    {X}

    scratch image sizes

    gdk/gdk.symbols

    {X}

    guard maemo symbols in MAEMO_CHANGES #ifdefs

    gdk/makegdkalias.pl

    {X}

    support #ifdef MAEMO_CHANGES

    gdk/x11/gdkdisplay-x11.c

    {X}

    allow to disable XSHM (env GDK_DISABLE_XSHM)

    gdk/x11/gdkinput-x11.c

    (./)

    follow the Xi spec more closely when translating coords

    gdk/x11/gdkmain-x11.c

    {X}

    Use g_error() on X errors, so testers get core dumps

    gtk/Makefile.am

    {X}

    move gtkfilesystem.h, gtkfilesystemmodel.h, gtkfilechooserprivate.h, gtkfilechooserutils.h from private to semi-private

    gtk/Makefile.am

    {X}

    compile with -DGTK_FILE_CHOOSER_ENABLE_UNSUPPORTED

    gtk/Makefile.am

    {X}

    define MAEMO_CHANGES in the gtktypebuiltins.c rule

    gtk/makegtkalias.pl

    {X}

    support #ifdef MAEMO_CHANGES

    gtk/gtk.symbols

    Add symbols new in Maemo-GTK+; guard them in MAEMO_CHANGES #ifdefs

    gtk/gtkarrow.c

    (./)

    add "maemo-min-size" and "maemo-aspect-ratio" style properties

    gtk/gtkbbox.{c,h}

    (./)

    refactor into _gtk_button_box_child_size_props

    gtk/gtkbutton.c

    (./)

    M66 separator-height style property

    gtk/gtkbutton.c

    {X}

    set tap-and-hold-state to GTK_STATE_ACTIVE

    gtk/gtkbutton.{c,h}

    S

    hildon_gtk_button_set_depressed()

    gtk/gtkcellrenderercombo.c

    (./)

    Add "changed" signal

    gtk/gtkcellrenderertext.c

    /!\

    changes to xpad, ypad defaults

    gtk/gtkcellrenderertext.c

    {X}

    render cell with normal state in prelight mode (might need back out later, since this is only triggered by motion events)

    gtk/gtkcellrenderertext.c

    /!\

    don't set xpad, ypad to 2

    gtk/gtkcellrenderertoggle.c

    /!\

    set toggle width default to 26

    gtk/gtkcellrenderertoggle.c

    (./)

    follow insensitive state of widget

    gtk/gtkcellview.c

    {X}

    different size allocation algorithm

    gtk/gtkcellview.c

    (./)

    propagate insensitive state to cell renderers

    gtk/gtkcombobox.c

    {X}

    propagate insensitive press from combo box child

    gtk/gtkcombobox.c

    (./)

    ::autodimmed-button propery for insensitive button on empty models

    gtk/gtkcombobox.c

    ?

    unset CAN_FOCUS on the button if the child is a GtkEntry, grab focus on the entry when button is clicked

    gtk/gtkcontainer.c

    Port support for tap-and-hold

    gtk/gtkcontainer.c

    {X}

    Remove all instances from container from size_allocated_containers when it is destroyed

    gtk/gtkcontainer.c

    {X}

    Only add toplevels to size_allocated_containers list

    gtk/gtkcontainer.c

    {X}

    On adjustment updates after a container resize, only force focussed widget to be visible if it is smaller than the viewport.

    gtk/gtkcontainer.c

    {X}

    adjust scroll area around focussed widget for every window after any container got resized via _gtk_container_post_size_allocate()

    gtk/gtkcontainer.h

    {X}

    added _gtk_container_post_size_allocate()

    gtk/gtkentry.c

    hildon-input-mode IM property proxying/API

    gtk/gtkentry.c

    ::invalid_input() signal, filter_text() function

    gtk/gtkentry.c

    connect to IM clipboard signals

    gtk/gtkentry.c

    various IM method calling changes/additions

    gtk/gtkentry.c

    /!\

    truncation enabled by default

    gtk/gtkentry.c

    (./)

    Resize completion popup in gtk_entry_size_allocate

    gtk/gtkentry.h

    hildon-input-mode API

    gtk/gtkentry.h

    ::invalid_input() signal

    gtk/gtkentry.h

    {X}

    hildon_gtk_entry_set_progress_adjustment

    gtk/gtkentry.c

    {X}

    Added progressbar display in entry background

    gtk/gtkentrycompletion.c

    (./)

    constrain popup size to fit on screen

    gtk/gtkentrycompletion.c

    ?

    make popup positioning hildon-friendly (bogus?)

    gtk/gtkentrycompletion.c

    don't add pointer grab to popup window (retain focus for IM)

    gtk/gtkenums.h

    {X}

    GtkInvalidInputType, HildonGtkInputMode, HildonMode, HildonUIMode

    gtk/gtkfilechooserprivate.h

    {X}

    add #ifndef GTK_FILE_CHOOSER_ENABLE_UNSUPPORTED guard

    gtk/gtkfilechooserutils.{c,h}

    {X}

    export _gtk_file_chooser_install_properties() via hildon_gtk_file_chooser_install_properties()

    gtk/gtkfilechooserutils.c

    {X}

    add #include "gtkaliasdef.c"

    gtk/gtkfilechooserutils.h

    {X}

    add #ifndef GTK_FILE_CHOOSER_ENABLE_UNSUPPORTED guard

    gtk/gtkfilesystem.[c,h]

    {X}

    Add gtk _file_info_set_icon_pixbuf

    gtk/gtkfilesystem.h

    {X}

    add GTK_FILE_SYSTEM_ERROR_TIMEOUT

    gtk/gtkfilesystemmodel.h

    {X}

    add #ifndef GTK_FILE_SYSTEM_ENABLE_UNSUPPORTED guard

    gtk/gtkhbbox.c

    (./)

    better handling for allocation < requisition

    gtk/gtkhbbox.c

    (./)

    support heterogeneous size allocation

    gtk/gtkiconcachevalidator.c

    {X}

    adapt max value of "flags" due to addition ANI in updateiconcache.c

    gtk/gtkiconfactory.c

    {X}

    Initialize Hildon icon sizes

    gtk/gtkicontheme.c

    {X}

    Port of support for animations

    gtk/gtkiconview.c

    (./)

    Paint the selection around the whole item and improve themeability

    gtk/gtkiconview.c

    {X}

    Handle hildon-ui-mode property

    gtk/gtkiconview.c

    {X}

    Render tickmarks over icons in some cases

    gtk/gtkiconview.c

    {X}

    Alter row selection and activation behavior

    gtk/gtkiconview.c

    {X}

    Disable cursor related code

    gtk/gtkiconview.c

    {X}

    Enforce a row to be selected in single selection mode

    gtk/gtkiconview.c

    {X}

    Support for row headers; tweaks to layouting algorithm, item paint routine, selection code and key navigation

    gtk/gtkiconview.h

    {X}

    Support for row headers

    gtk/gtkimcontext.c

    added GtkIMContextPrivate, hildon-input-mode property

    gtk/gtkimcontext.c

    added has-selection, clipboard-operation signals

    gtk/gtkimcontext.c

    implement filter_event handler

    gtk/gtkimcontext.c

    added hildon_gtk_im_context_filter_event()

    gtk/gtkimcontext.c

    added gtk_im_context_show(), gtk_im_context_hide() (and the same prefixed with hildon_)

    gtk/gtkimcontext.c

    added hildon_gtk_im_context_has_selection(), hildon_gtk_im_context_{cut,copy,paste}()

    gtk/gtkimcontext.h

    GtkIMContextClipboardOperation, new signals, hildon_gtk_im_context_filter_event(), new API for signals

    gtk/gtkimmodule.c

    Drop "const" from _gtk_im_module_get_default_context_id()

    gtk/gtkimmodule.h

    Drop "const" from _gtk_im_module_get_default_context_id()

    gtk/gtkimmulticontext.c

    replace constant global_context_id string with get_global_context_id() function and update code dealing with global_context_id

    gtk/gtkimmulticontext.c

    port _{set,get}_property methods

    gtk/gtkimmulticontext.c

    add signal handlers for has-selection, clipboard-operation, input-mode-changed

    gtk/gtkimmulticontext.c

    handle notifications of hildon-input-mode property

    gtk/gtkimmulticontext.c

    implement filter_event, show, hide handlers

    gtk/gtkimmulticontext.h

    (./)

    dropped const on context_id in GtkIMMultiContext

    gtk/gtklabel.c

    {X}

    wrap at 85% (now 75%) of screen instead of 50% See 101968 for the real extended layout solution.

    gtk/gtkmain.c

    {X}

    adaptions for ::insensitive_press

    gtk/gtkmarshalers.list

    (./)

    VOID:STRING,BOXED for GtkCellRendererCombo::changed

    gtk/gtkmenu.{c,h}

    _gtk_menu_{push,pop}_context_menu_behavior()

    gtk/gtkmenu.c

    implemented Maemo context menu handling

    gtk/gtkmenu.c

    {X}

    added widget names (HILDON_MENU_NAME*) for Maemo specific rc-files. Trying to figure out if we can do this without patching gtkmenu

    gtk/gtkmenu.c

    {X}

    added gtk_menu_check_name() to help with HILDON_MENU_NAME*. Trying to figure out if we can do this without patching gtkmenu

    gtk/gtkmenu.c

    changed window from popup to toplevel without decorations

    gtk/gtkmenu.c

    added visibility notify handling (popdown when obscured)

    gtk/gtkmenu.c

    save/ restore pointer position across popups

    gtk/gtkmenu.c

    (./)

    remove scroll arrow background painting

    gtk/gtkmenu.c

    add 20 pixel proximity thresholds (N770 spec)

    gtk/gtkmenu.c

    close context menus beyond pixel threshold in gtk_menu_motion_notify()

    gtk/gtkmenu.c

    call _gtk_menu_shell_set_first_click()

    gtk/gtkmenu.c

    (./)

    scroll on click in touchscreen mode

    gtk/gtkmenu.c

    (./)

    move scroll arrows to the bottom

    gtk/gtkmenu.c

    (./)

    add maemo-arrow-scaling style property

    gtk/gtkmenu.c

    (./)

    invoke accels even though menu is open

    gtk/gtkmenuitem.c

    submenu indicator draws differently when submenu is visible

    gtk/gtkmenuitem.c

    (./)

    reduce the minimum width of menuitems

    gtk/gtkmenushell.c

    make navigation to GTK_MENU_DIR_PARENT always close exactly one submenu

    gtk/gtkmenushell.c

    {X}

    ::insensitive-press support

    gtk/gtkmenushell.c

    add _gtk_menu_shell_fake_button_events() to forward clicks when clicking outside

    gtk/gtkmenutoolbutton.c

    {X}

    chain ::insensitive-press from the internal arrow

    gtk/gtkmessagedialog.c

    {X}

    do not show the titlebar

    gtk/gtknotebook.c

    /!\

    notebooks scrollable by default; pages expanded by default

    gtk/gtknotebook.c

    {X}

    Show tabs for invisible pages

    gtk/gtknotebook.c

    (./)

    Pass extra notebook_show_arrow detail to theme engine

    gtk/gtkprogressbar.c

    (./)

    minimum height adjustment

    gtk/gtkprogressbar.c

    /!\

    set text-xalign to 0.0

    gtk/gtkquery.c

    make semi-private instead of private

    gtk/gtkradiobutton.c

    {X}

    Make TAB_FORWARD/BACKWARD behave as UP/DOWN. We have the inverse mapping for all dialogs, but it's wrong here

    gtk/gtkrange.c

    (./)

    arrow-scaling style property (arrow images)

    gtk/gtkrange.{c,h}

    (./)

    M31 stream-indicator/position API

    gtk/gtkrbtree.{c, h}

    {X}

    allow for setting a base offset (used for GtkTreeView action area)

    gtk/gtkrc.c

    {X}

    parse old hildon logical color format

    gtk/gtkrc.c

    {X}

    attempt to read .cache file before parsing

    gtk/gtkrc.c

    {X}

    parse theme and key theme first (makes styles available when parsing with gtk_rc_context_parse_string)

    gtk/gtksearchengine.c

    make semi-private instead of private

    gtk/gtkstyle.c

    {X}

    gtk_style_lookup_logical_color() (deprecated in Maemo)

    gtk/gtkstyle.h

    {X}

    provide old hidon logical color API

    gtk/gtktextbuffer.{c,h}

    (./)

    M30 gtk_text_buffer_set,get_can_paste_rich_text(), gtk_text_buffer_set,get_rich_text_format()

    gtk/gtktextview.c

    hildon-input-mode property proxying/API

    gtk/gtktextview.c

    connect to IM clipboard signals

    gtk/gtktextview.c

    {X}

    keep cursor visible in size_allocate() (this patch is now removed from maemo-gtk)

    gtk/gtktextview.c

    call IM's filter_event()

    gtk/gtktextview.c

    various IM reset changes

    gtk/gtktextview.c

    ?

    include previous whitespace in retreive_surrounding_handler()

    gtk/gtktextview.c

    (./)

    in _set_buffer(): always set the buffer on the layout to NULL

    gtk/gtktextview.c

    (./)

    in _set_buffer(): clear pending scroll

    gtk/gtktextview.c

    (./)

    in _set_buffer(): unref buffer after removing the selection from clipboard

    gtk/gtktextview.c

    (./)

    in _queue_scroll(): bail out if the given mark is not in text view's current buffer

    gtk/gtktextview.c

    (./)

    in _value_changed(): also update the IM spot location before running _validate_onscreen()

    gtk/gtktextview.h

    hildon-input-mode API

    gtk/gtktoolbutton.c

    {X}

    add support for insensitive-press

    gtk/gtktoolbutton.c

    proxy tap-and-hold signals for the GtkButton inside GtkToolButton

    gtk/gtktreemodelfilter.c

    {X}

    don't assert in gtk_tree_model_filter_row_has_child_toggled()

    gtk/gtktreeprivate.h

    {X}

    change TREE_VIEW_DRAG_WIDTH to 28 (affects size of area around column separators where resizing drag can be started)

    gtk/gtktreeselection.c

    {X}

    make sure cursor is on selected row when switching to a single selection mode

    gtk/gtktreeselection.c

    ?

    small optimization in tree_column_is_sensitive

    gtk/gtktreeselection.c

    {X}

    make _gtk_tree_selection_row_is_selectable check for row sensitivity

    gtk/gtktreeselection.c

    {X}

    allow for unselecting an insensive row (this might have to go upstream)

    gtk/gtktreeselection.c

    {X}

    use gtk_tree_view_column_set_cell_data_with_hint() where applicable

    gtk/gtktreeselection.c

    {X}

    implement different row selection behaviors

    gtk/gtktreeselection.c

    {X}

    Support for row headers

    gtk/gtktreeview.c

    {X}

    Port of tap-and-hold support

    gtk/gtktreeview.c

    {X}

    drag selection (pen dragging) (ported by modifying the upstream rubber banding code to resemble Maemo pen dragging, discontinuous selection has been dropped -- NOTE: needs more testing when hildon-fm port has been finalized)

    gtk/gtktreeview.c

    {X}

    row-insensitive signal (test when hildon-fm is finalized)

    gtk/gtktreeview.c

    {X}

    don't allow cursor to reach insensitive rows (keyboard)

    gtk/gtktreeview.c

    {X}

    tap on row expands/collapses

    gtk/gtktreeview.c

    row-activate on single tap, but not until button-release, disable double click handling

    gtk/gtktreeview.c

    /!\

    headers invisible by default

    gtk/gtktreeview.c

    {X}

    scroll to expanding row (except for the bit that takes collapsing branches above into account, since that doesn't happen anymore)

    gtk/gtktreeview.c

    /!\

    M41 expander indent (default value 10) (set value of 2.10 level-indentation property to 10)

    gtk/gtktreeview.c

    {X}

    don't indent first level (handled by level-indentation property)

    gtk/gtktreeview.c

    (./)

    separator height style property

    gtk/gtktreeview.c

    ?

    cursor follows selection handler (still needed?)

    gtk/gtktreeview.c

    {X}

    unselect insensitive rows in row_changed

    gtk/gtktreeview.c

    /!\

    M60 drop + 2 in gtk_tree_view_queue_draw_arrow (patched by setting the 2.10 show-expanders property to FALSE by default)

    gtk/gtktreeview.c

    /!\

    M60 disable expanders (patched by setting the 2.10 show-expanders property to FALSE by default)

    gtk/gtktreeview.c

    {X}

    paint drop indicator before cells

    gtk/gtktreeview.c

    {X}

    move focus if we can't expand/collapse

    gtk/gtktreeview.c

    {X}

    real_set_cursor() should not set cursor on insensitive rows (depends on row-insensitive signal)

    gtk/gtktreeview.c

    {X}

    consider rows with only one special cell as not having special cells to get the focus rectangle over the whole row

    gtk/gtktreeview.c

    (./)

    bail out of gtk_tree_view_focus() if can-focus is false

    gtk/gtktreeview.c

    {X}

    don't start edge scrolling as soon as we receive a motion event

    gtk/gtktreeview.c

    {X}

    skip headers when acquiring focus

    gtk/gtktreeview.c

    {X}

    Clear all pending actions if we decide to start a drag in maybe_beging_dragging_row()

    gtk/gtktreeview.c

    Stop rubberbanding on row-deleted

    gtk/gtktreeview.c

    {X}

    use gtk_tree_view_column_set_cell_data_with_hint() where applicable

    gtk/gtktreeview.c

    {X}

    row-height style property

    gtk/gtktreeview.c

    (./)

    make fixed-height-mode and row-separator-func play nice

    gtk/gtktreeview.c

    (./)

    queue a resize when a new row separator func is set

    gtk/gtktreeview.c

    {X}

    handle hildon-ui-mode property

    gtk/gtktreeview.c

    {X}

    render tickmarks right of last column in some cases

    gtk/gtktreeview.c

    {X}

    alter row selection and activation behavior

    gtk/gtktreeview.c

    {X}

    enforce a row to be selected in single selection mode

    gtk/gtktreeview.c

    {X}

    disable cursor related code

    gtk/gtktreeview.c

    {X}

    Support for row headers; updates to validate, expose and selection code

    gtk/gtktreeview.c

    {X}

    introduce hildon-row-tapped signal

    gtk/gtktreeview.c

    {X}

    do not activate interactive search when enter/space is pressed

    gtk/gtktreeview.c

    {X}

    allow for an action area via action-area-visible and action-area-orientation properties

    gtk/gtktreeview.c

    {X}

    properly handle rows-offset based on action area status

    gtk/gtktreeview.h

    {X}

    add row_insensitive signal

    gtk/gtktreeview.h

    {X}

    Support for row headers

    gtk/gtktreeview.h

    {X}

    allow for an action area

    gtk/gtktreeviewcolumn.c

    (./)

    column header alignment changes

    gtk/gtktreeviewcolumn.c

    ?

    added _set_cell_data variants (_for_validation and _with_attributes)

    gtk/gtktreeviewcolumn.c

    {X}

    add gtk_tree_view_column_set_cell_data_with_hint() and gtk_tree_view_column_get_cell_data_hint()

    gtk/gtkwidget.c

    {X}

    Maemo specific customization hooks in constructed()

    gtk/gtkwidget.c

    (./)

    Port of tap-and-hold implementation

    gtk/gtkwidget.c

    {X}

    insensitive-press

    gtk/gtkwidget.c

    {X}

    Added "maemo-position-theming" style property

    gtk/gtkwidget.c

    {X}

    call _gtk_container_post_size_allocate() at the end of gtk_widget_size_allocate()

    gtk/gtkwidget.c

    {X}

    (gtk_widget_size_allocate): only add toplevels to size_allocated_containers list

    gtk/gtkwidget.c

    {X}

    introduce hildon-mode style property

    gtk/gtkwidget.c

    (tap and hold) custom boolean accumulator for handling the tap-and-hold-query signal correctly

    gtk/gtkwidget.h

    (./)

    Port of tap-and-hold implementation

    gtk/gtkwidget.h

    {X}

    insensitive-press

    gtk/gtkwindow.{c,h}

    {X}

    M23 gtk_window_set,get_prev_focus_widget()

    gtk/tests/iconview-hildon.c

    {X}

    new test

    gtk/tests/Makefile.am

    {X}

    add new Maemo specific tests to test suite, only build these when --with-maemo enabled

    gtk/tests/treeview-hildon.c

    {X}

    new test

    gtk/updateiconcache.c

    {X}

    Port of animation support

    tests/autotestfilechooser.c

    {X}

    GTK_FILE_CHOOSER_ENABLE_UNSUPPORTED

    tests/Makefile.am

    {X}

    add new tests

    tests/testhildontreeview.c

    {X}

    new test

    tests/testhildoniconview.c

    {X}

    new test

    gtk/gtkstyle.c

    {X}

    clamp cursor coordinates to window bounds

    gtk/gtkwindow.{c,h}

    ?

    gtk_window_close_other_temporaries()

    gtk/gtkrc.c

    (./)

    Optimize is_c_identifier

    gtk/gtktextview.c

    {X}

    Paint shadow conditional to hildon-mode

    gtk/gtkrange.c

    (./)

    Jump directly instead of steps with jump-to-position

    gtk/gtkdnd.c

    {X}

    Disable DND unconditionally

    gtk/gtkdialog.c

    ?

    Properties top-, left, bottom- right-padding, inner-spacing


Maemo-GLib changes compared to upstream GLib

  • File

    Status

    Comments

    configure.in

    Atomic operations for ARM

    glib/gatomic.c

    Atomic operations for ARM

Attic/Maemo/MaemoGtkChanges (last edited 2013-11-23 01:26:52 by WilliamJonMcCann)